MetaMask / MetaMask/metamask-extension
[e2e] Update `errors.spec.js` by inspecting error report to ensure stack trace is included
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
**Context**:
> I'm noticing on Sentry that there are no stack traces for any errors on Firefox
> Not a sourcemap issue. The raw JSON error report Sentry is getting is missing a stack trace. It's an instrumentation issue.
Example:
https://sentry.io/organizations/metamask/issues/2107679955/
**What**: update `error.spec.js` by catching the Sentry request and inspecting the error report to ensure it includes a stack trace (at least for errors with a stack trace). Maybe it's just a matter of updating the Sentry library.
See more [here](https://consensys.slack.com/archives/GTQAGKY5V/p1665525545931549).
Reported by @Gudahtt
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with errors.spec.js and inspect how the existing end-to-end test observes Sentry requests. Catch the request, examine the raw error report, and make the test verify that errors with stack traces include one; confirm the test passes with the relevant Firefox scenario.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- observability, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100