MetaMask / MetaMask/metamask-extension

minimize bundle size taken by eth-phishing-detect

Open
#15,030 0 comments 0 reactions 0 assignees View on GitHub
MV3 team-extension-platform
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

Dan M editing on Aug 10:

eth-phishing-detect has huge list of words https://output.circle-artifacts.com/output/job/0b87725e-d9fa-4b1e-87c8-209ba5bb939a/artifacts/0/build-artifacts/source-map-explorer/common-2.html

Two options:
1. Build config.json in a similar way to how we build the locale files, so that it need not be part of the background bundle
2. This can be replaced by regex https://consensys.slack.com/archives/C02DUDT2WTU/p1655939118095499

We should try for 1 first

Contributor guide

Open the contributing guide

Research direction

Start with the source-map-explorer report linked in the issue and compare how locale files are built. Trace where eth-phishing-detect's config.json enters the background bundle, then verify that the chosen approach removes the word list from that bundle and reduces its size.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
build-system, performance
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.