MetaMask / MetaMask/metamask-extension

[Sentry Bug]: eth-query Sentry error is a catch-all bucket for a variety of errors

Open
#14,892 0 comments 1 reaction 0 assignees View on GitHub
area-sentry stability team-extension-platform
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

### Describe the bug

Sentry grouping consolidates a variety of errors into one error. We should create a solution, and likely multiple solutions over time, to split the errors apart to address the errors individually.

This ticket is to separate the eth-query Sentry errors.

Related Sentry Issue: https://sentry.io/organizations/metamask/issues/2050334766/
Related GitHub Sentry Issue: https://github.com/MetaMask/metamask-extension/issues/10552

In the related Sentry issue, relevant error details are omitted from the contributing values used to create the fingerprint for Sentry error grouping. This is because the value has been sent over as a string and is "(discarded because line too long)".

Once a solution for this issue has been created, please close the related [GitHub Sentry Issue.]( https://github.com/MetaMask/metamask-extension/issues/10552)

### Steps to reproduce

1. View one of the [Sentry Issue's](https://sentry.io/organizations/metamask/issues/2050334766/?project=273505&referrer=github_integration) events [(example Event)](https://sentry.io/organizations/metamask/issues/2050334766/?project=273505&referrer=github_integration)
2. Scroll to "EVENT GROUPING INFORMATION" at the bottom of the page
3. Click "Show Details" to expand this section
4. Observe "Contributing values" are missing values from "All Values"

Example:
Screenshot 2022-06-07 at 2 29 18 PM

### Error messages or log output

Example a few errors being thrown:

{“code":-32000,"message":"header not found"}

https://sentry.io/organizations/metamask/issues/2050334766/events/72a70d8104c14f74a88855ad87143ca8/?project=273505
https://sentry.io/organizations/metamask/issues/2050334766/events/9e1c1afd3f58471993ec371a6f661d70/?project=273505
{"code":-32603,"message":"submit transaction to pool failed: Pool(InvalidTransaction(InvalidTransaction::Custom(5)))"}

https://sentry.io/organizations/metamask/issues/2050334766/events/44085c21392f4b1b9772b3e3a4e8ada4/?project=273505
{"code":-32000,"message":"invalid nonce; got 4, expected 5: invalid sequence: invalid sequence"}

https://sentry.io/organizations/metamask/issues/2050334766/?project=273505
{"code":-32000,"message":"invalid nonce; got 6, expected 4: invalid sequence: invalid sequence"}

https://sentry.io/organizations/metamask/issues/2050334766/events/99ab15bacb514d2b92b41b286ab595a6/?project=273505
{"code":-32000,"message":"nonce too low"}

https://sentry.io/organizations/metamask/issues/2050334766/events/9790ed8f69a34cd08c21a6527472e348/?project=273505
{"text":"The requested URL was not found on this server.","code":404}

https://sentry.io/organizations/metamask/issues/2050334766/events/3f4b46d13e824d4cb63df8d6e5acdd80/?project=273505
{"code":-32000,"message":"cannot query unfinalized data"}

https://sentry.io/organizations/metamask/issues/2050334766/events/4992c8b6a7a943a68ca2a43dd45f8f1d/?project=273505
{"code":-32000,"message":"replacement transaction underpriced"}

https://sentry.io/organizations/metamask/issues/2050334766/?project=273505
{"statusCode":404,"message":"Cannot POST /v3/***************************,”error":"Not Found"}

https://sentry.io/organizations/metamask/issues/2050334766/events/610b433d07914ad49cb35b1890410be3/?project=273505
https://sentry.io/organizations/metamask/issues/2050334766/events/4af71ea52f3c494489b039c4064fc543/?project=273505
{"jsonrpc":"2.0","error":{"code":429,"message":"RATE LIMIT EXCEEDED 1000 REQ/MIN"}}

https://sentry.io/organizations/metamask/issues/2050334766/events/8226efc8d9d24d8a95768d0ffe973f47/?project=273505
{"request":{"id":9386771847354,"jsonrpc":"2.0","params”:[“0”x1******************,”0x1a1b7f8"],"method":"eth_getTransactionCount"}}

https://sentry.io/organizations/metamask/issues/2050334766/events/2ab4391758404443b67bfbfb2afa1213/?project=273505
{"code":-32000,"message":"insufficient funds for gas * price + value"}

https://sentry.io/organizations/metamask/issues/2050334766/events/ddbe08a9f2e548f8abfea77442db7d12/?project=273505
{“code":-32000,"message":"state not found”}

fragment: confirm-transaction/3652122307529776/send-ether
event: https://sentry.io/organizations/metamask/issues/2050334766/events/af5a171e096046cfa91b39275cb02242/?project=273505

### Version

10.14.7

### Build type

_No response_

### Browser

Other (please elaborate in the "Additional Context" section)

### Operating system

Other (please elaborate in the "Additional Context" section)

### Hardware wallet

_No response_

### Additional context

Browser and OS are irrelevant to this bug or Sentry feature request

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the linked Sentry issue, related GitHub issue #10552, and the example events to understand how eth-query errors are currently grouped. Done means the distinct errors are separated into useful Sentry groups and the related GitHub issue can be closed.

Written by the indexing model from the issue text.

Assessment

Domain
observability
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.