MetaMask / MetaMask/metamask-extension
Improve default naming of accounts
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
We allow so many hardware wallets now, and with Ledger any number of hardware wallet cards, it's basically impossible to keep up by just adding numbers in the order they were added.
Proposed new account naming scheme:
`${accountType} ${accountType.number} account ${derivationIndex + 1}`
Examples:
- If you have 2 Grid+ Lattice cards, the third account on your second card would be `Lattice 2 account 3`.
This is a total MVP solution that I think will make this a bit better.
Longer term, we should enable nicknaming on a per-keychain basis, and so that keychain's nickname should be auto-prepended in some easily scanable form over the account list item.
Contributor guide
Research direction
Search the repository for the existing default account-name generation and the hardware-wallet account list entry point. Compare the current behavior with the proposed accountType, accountType.number, and derivationIndex format; done means names distinguish multiple hardware wallets and accounts as shown in the Lattice example.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100