MetaMask / MetaMask/metamask-extension

Handle `FILE_ERROR_NO_SPACE` error gracefully

Open
#14,525 8 comments 0 reactions 1 assignee Claimed by @rachelcope View on GitHub
area-sentry area-storage
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

We currently see many instances of the error `FILE_ERROR_NO_SPACE` in Sentry. These errors occur when a user runs out of disk space and state persistence of app related state fails.

Currently these errors are not surfaced to the user meaning that we will not persist state which may result in unexpected or buggy behavior in the extension and fail to warn the user as to why they may be experiencing buggy behavior.

- [ ] We should intercept these errors and show the user a legible error message that will either help them resolve the issue by freeing up space or at least clear up confusion about why the extension is failing to behave as expected.

- [ ] We should also move the logging of these errors from sentry to segment.

**For Design:**

**The lifecycle of this error notice needs a spec**
- Should we allow this to be dismissed? Or should we show this until the user does clear space?
- If we allow it to be dismissed, do we leave it dismissed forever? What if the user clears space, then it fills up again?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.