MetaMask / MetaMask/metamask-extension

Use `metamask-eth-abis` in extension's TransactionController

Open
#13,857 0 comments 0 reactions 0 assignees View on GitHub
type-enhancement
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

Currently we use the `human-standard-token-abi` for all token transactions. We should start using the recently created `metamask-eth-abis` to enhance our ability to parse and provide more accurate data for non ERC20 token (ERC721 and ERC1155) contract interactions.

Contributor guide

Open the contributing guide

Research direction

Start at the extension's TransactionController and locate its use of human-standard-token-abi. Compare the available metamask-eth-abis definitions for ERC721 and ERC1155, then trace the transaction parsing path. Done means non-ERC20 contract interactions are parsed with more accurate token data.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.