MetaMask / MetaMask/metamask-extension
(Ext) Hardware wallet quirk bug
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
Setup
- Have SRP1 on a Ledger
- Have SRP2 connected on a Grid+ Lattice
- Connect SRP1 on a Grid+ safe card, and open it on the Lattice
- In MM, open "Connect to hardware wallet"
- MM shows the SRP1 accounts
Problem
- The "continue/connect" button is disabled.
- The "forget this account" button is enabled.
Possible solutions
- Allow forgetting old Ledger accounts
- Allow Adding a hardware wallet account whose account may already be in the wallet, but is being connected by a different hardware wallet.
- Longer term, we should have a multi-hw-backup friendly flow: If a user has connected an address with multiple signers, (or even if not!), during signing users should have a path to "sign with [specific hardware wallet]", so users aren't stuck using an account with the first hardware wallet it is connected with.
Contributor guide
Research direction
Reproduce the Ledger, Grid+ Lattice, and safe card setup, then start from the “Connect to hardware wallet” flow described in the issue. Review the account-selection and connect/forget states; this is done only after the project agrees on whether to forget the old account, add the account through another hardware wallet, or design the longer-term multi-wallet signing flow.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend, security
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100