MetaMask / MetaMask/metamask-extension

Accurate reporting of user-facing language changes

Open
#13,773 2 comments 0 reactions 0 assignees View on GitHub
area-contractAccounts area-documentation area-permissions type-enhancement
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

### Describe the bug

The most recent change for the `eth_accounts` text is a welcome update to the previous change. It is much clearer.

I feel however that due to the extremely large user-base of MetaMask and there being users of varying levels of technical ability, it would be important to have a system of acknowledging / documenting when there are language changes to important user-facing messages.

When the previous change was made from it caused a significant flurry among a few of the NFT discords that I am moderating for.

When that happened, I checked MetaMask's social media, then checked github, and only could find confirmation that it was a change when I dug through the changed files to confirm that the message we were now seeing was in fact a valid update that had been pushed to the code.

I think it should be at least documented in the changelog for commits so it's easy to verify.

I do also think, that it would be a good idea to show in the confirmation the label of the permission that is being granted - this way people can see that even if the text has changed slightly, they're still only granting the `eth_accounts` permission and this would alleviate some of the concerns when it comes to mild grammatical changes to user-facing interactions.

### Steps to reproduce

A hoverable question-mark tooltip could be an elegant solution as pictured:

![image](https://user-images.githubusercontent.com/20593811/155775004-25a6beb7-2537-49e1-8ff0-d6c03784ab1d.png)

Or this as pictured:

![image](https://user-images.githubusercontent.com/20593811/155775378-28450553-0525-4104-9352-20d8545c9196.png)

I think this is extremely important to encourage awareness of the interactions that users are conducting with regards to MM - as many users do not understand the fundamentals of blockchain and websites asking for strange permissions is still a consistent attack vector.

I would be happy to work on a fork and PR for these changes if it was supported.

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the existing eth_accounts user-facing confirmation and how language changes are recorded in the changelog. The issue suggests either documenting message changes or adding a permission label and tooltip, but does not identify files, tests, or a settled implementation. Done would require an agreed scope and verification that users can understand the permission and confirm language changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.