MetaMask / MetaMask/metamask-extension
[Bug]: Icon being lost between token screen and swaps screen
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
Describe the bug
The icon for a given token is not displayed in the swaps dropdown but is on the token's feature screen.
Steps to reproduce
- Click into a given token from the listing -- see the correct icon
- Click the "swap" button
- Land on the swaps page, but see the missing icon circle with the first letter of the token name
Error messages or log output
No response
Version
10.9.2
Build type
No response
Browser
Brave
Operating system
MacOS
Hardware wallet
No response
Additional context
Video of the issue:
https://user-images.githubusercontent.com/46655/153979597-20ae51ce-e8d8-4101-b8a6-c9c6b674541a.mp4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing how the token feature screen and swaps dropdown receive and render the token icon. Reproduce the flow from a token listing through the Swap button in MetaMask 10.9.2 using Brave on macOS, then trace the differing data or rendering path. Done means the correct token icon appears in the swaps dropdown instead of the fallback initial.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100