MetaMask / MetaMask/metamask-extension

Video/Audio NFT support

Open
#13,607 3 comments 0 reactions 1 assignee Claimed by @adonesky1 View on GitHub
area-NFTs team-assets
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

Currently we assume all NFTs are image based and do not support other types of media (though we link to them).
A couple of scenarios to consider:

1. OpenSea currently provides us a snapshot image even when an NFT is actually a video, but when a user imports an NFT and have OpenSea turned off we are displaying nothing.

2. Again if we don't have a snapshot from OpenSea because the user has turned off the OpenSea API **AND** the original image is hosted on a protocol like IPFS where the file type is not accessible from the URL we cannot know before hand whether it is an image or video/audio and therefore cannot know what tag (`` or ``) to pass it to. There may be [ways to extract the file type programmatically](https://github.com/ipfs/js-ipfs/issues/3473) from the ipfs url, but this will require some further research.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.