MetaMask / MetaMask/metamask-extension

lavamoat whitelist error when building master

Open
#13,253 7 comments 4 reactions 0 assignees View on GitHub
area-buildSystem contributor experience
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

When I pull the latest master branch copy and try to build, I get the following error.

1. I ran yarn setup
2. I ran yarn build dev
3. Got the error:

Error: LavaMoat - required node builtin package not in whitelist: package "@nodelib\fs.stat" requested "fs" as "fs"
at requireRelative (LavaMoat/core/kernel:519:15)
at requireRelativeWithContext (LavaMoat/core/kernel:471:16)
at Object.eval (D:\projects\nft\metamask\node_modules\@nodelib\fs.stat\out\adapters\fs.js:4:12)
at internalRequire (LavaMoat/core/kernel:458:25)
at requireRelative (LavaMoat/core/kernel:499:27)
at requireRelativeWithContext (LavaMoat/core/kernel:471:16)
at Object.eval (D:\projects\nft\metamask\node_modules\@nodelib\fs.stat\out\settings.js:4:12)
at internalRequire (LavaMoat/core/kernel:458:25)
at requireRelative (LavaMoat/core/kernel:499:27)
at requireRelativeWithContext (LavaMoat/core/kernel:471:16)

I am running node 14.15.1, yarn 1.22.17.

I also tried running this:

yarn add @nodelib\fs.stat

I then ran yarn build dev again, and got this error:

TypeError: Cannot assign to read only property 'name' of function 'function createError(opts) {
var result = new Error();
Object.defineProperty(result, 'type', {...... }'

at extend (D:\projects\nft\metamask\node_modules\xtend\mutable.js:12:29)
at TypedError (D:\projects\nft\metamask\node_modules\error\typed.js:26:5)
at Object.eval (D:\projects\nft\metamask\node_modules\body\any.js:10:28)
at internalRequire (LavaMoat/core/kernel:458:25)
at requireRelative (LavaMoat/core/kernel:499:27)
at requireRelativeWithContext (LavaMoat/core/kernel:471:16)
at Object.eval (D:\projects\nft\metamask\node_modules\tiny-lr\src\server.js:36:12)
at internalRequire (LavaMoat/core/kernel:458:25)
at requireRelative (LavaMoat/core/kernel:499:27)
at requireRelativeWithContext (LavaMoat/core/kernel:471:16)

Any ideas? I'm very unfamiliar with lavamoat...

Contributor guide

Open the contributing guide

Research direction

Reproduce the failure with yarn setup and yarn build dev using the reported Node and Yarn versions. Start with the LavaMoat/core/kernel stack frames and the @nodelib/fs.stat and tiny-lr dependency paths shown in the errors. Done means the development build completes without either reported LavaMoat or read-only-property error.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.