MetaMask / MetaMask/metamask-extension
Send max rounding error
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
**Describe the bug**
For some combinations of amount and suggested fees, sending max results in being shown an insufficient funds error on the confirmation screen. Decreasing maxFeePerGas by 1 wei allowed me to proceed.
**Steps to reproduce (REQUIRED)**
Send
Select/enter address
Click max
Click next
Unable to click confirm
**Browser details (please complete the following information):**
- Browser: Chrome 93.0.4577.82
- MetaMask Version: 10.1.1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The payload names no files or tests. Start by tracing the Send flow from selecting an address through Max and Next to the confirmation screen, focusing on how the amount and maxFeePerGas are checked. Done means affected fee combinations no longer show a false insufficient-funds error and can proceed to confirmation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100