MetaMask / MetaMask/metamask-extension
Show full ether precision on confirmation screen
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
On Moving from SEND to confirmation screen, small quantities of WEI are rounded off, appearing to throw away a user-input parameter.
Repro: try sending `1.0000000000000001` ether. See that it is not represented on the confirmation screen, either in the top value or in the "total".
This can be scary, if interacting with a contract that requires a precise number. The confirmation screen should show actual precision of ether values.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue by sending `1.0000000000000001` ether through the SEND flow and inspect the confirmation screen's top value and total. Trace the confirmation-screen formatting from the displayed value back to the input, then verify that both values preserve the actual ether precision.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100