MetaMask / MetaMask/metamask-extension

Update getBlockExplorerUrlForTx to use etherscan-link

Open
#10,749 0 comments 0 reactions 0 assignees View on GitHub
type-refactor
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

`getBlockExplorerUrlForTx` (in `shared/modules/transaction.utils.js`) has its own approach for generating links for custom networks, but a better approach for this is already implemented in the etherscan-links library. We make `getBlockExplorerUrlForTx` less error prone by the appropriate `@metamask/etherscan-link` methods

Contributor guide

Open the contributing guide

Research direction

Start in shared/modules/transaction.utils.js at getBlockExplorerUrlForTx and read the existing custom-network URL logic. Check the available @metamask/etherscan-link methods, then confirm that the function produces the intended explorer links for custom networks without retaining its separate approach.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
blockchain
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.