MetaMask / MetaMask/metamask-extension

EIP712 Message text is shown twice

Open
#10,124 4 comments 1 reaction 0 assignees View on GitHub
needs-design type-enhancement
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

**Describe the bug**
When signing a message as per the EIP712 standard, the word "Message" shows up twice, which looks wierd.

**Steps to reproduce (REQUIRED)**
Sign any EIP712 standard message.

Screenshot 2020-12-28 at 1 26 37 AM

1. Example on [codesandbox](https://codesandbox.io/s/gracious-raman-id9cg?file=/src/index.js)
2. Connect your wallet and click on the sign button

**Expected behavior**
Only show the "Message" text once

Contributor guide

Open the contributing guide

Research direction

Use the linked CodeSandbox's src/index.js and its EIP712 signing flow to reproduce the duplicated label. Then trace the corresponding signing UI entry point in the extension and compare the rendered headings with the expected single “Message” label. Done means signing an EIP712 message displays “Message” only once.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.