MetaMask / MetaMask/github-tools

`changelog-check` seems to mistakenly perceive changes to package scripts as needing changelog entries

Open
#152 0 comments 0 reactions 0 assignees View on GitHub
team-core-platform
Dominant language
TypeScript
Stars
12
Forks
7
Avg merge
1d 1h
Merged PRs (30d)
10

Description

If you are in a monorepo and you update any of the package scripts, but don't update the changelogs for those packages, the `changelog-check` workflow will produce an error. (I haven't tested a polyrepo but I suspect the same thing would happen there.)

I don't think this should happen, I think we should exclude changes to `scripts`.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing the changelog-check workflow and how it classifies package script changes. Verify the behavior for monorepos and, if supported, polyrepos; done means script-only changes no longer require changelog entries while other changes retain the check.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
ci-cd, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.