MetaMask / MetaMask/eth-token-tracker

Upgrade `secp256k1` to >= 4.0.4 to address CVE-2024-48930

Open
#150 0 comments 0 reactions 0 assignees View on GitHub
team-wallet-framework wf-security
Dominant language
JavaScript
Stars
81
Forks
41
PR merge metrics
No merged PRs in 30d

Description

`secp256k1` is not a direct dependency of this project; it shows up in the dependency tree via `ganache`. `ganache`, and thus `secp256k1`, are development-only dependencies (they are used only for tests).

Unfortunately because development of `ganache` has ended, we cannot upgrade it to a version that uses a higher version of `secp256k1`. We may have to come up with another way of upgrade `secp256k1`.

## Acceptance Criteria

- `yarn why secp256k1` should display no instances of `secp256k1` using version < 4.0.4.

## References

See security advisory: https://github.com/MetaMask/eth-token-tracker/security/dependabot/31

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by running `yarn why secp256k1` and inspect how `ganache` brings it into the development dependency tree. Determine an upgrade or replacement path that removes every `secp256k1` version below 4.0.4, then rerun the command to verify the acceptance criterion.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
build-system, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.