MetaMask / MetaMask/eth-sig-util

Add working decryption failure test

Open
#75 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
TypeScript
Stars
583
Forks
228
Avg merge
11h 22m
Merged PRs (30d)
7

Description

Our current decryption failure test is incorrect, and is being removed:

It tests if an absent variable can decrypt a payload, and so it fails for the wrong reason: An error is thrown because `alice` does not exist, not because she cannot decrypt the variable.

Highlighted here:
https://github.com/MetaMask/eth-sig-util/pull/74#issuecomment-572330875

Contributor guide

No contributing guide indexed for this repository

Research direction

Read PR #74 and its linked comment first; the issue provides no file or test path. Locate the decryption failure test being removed, then ensure the replacement exercises failure to decrypt an existing payload rather than failure caused by a missing variable. Done means the test fails for the intended decryption reason and passes with the corrected behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
cryptography, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.