MetaMask / MetaMask/eth-sig-util

signTypedData: `uint` and `int` fields should be forbidden

Open
#55 1 comment 2 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
583
Forks
228
Avg merge
11h 22m
Merged PRs (30d)
7

Description

Right now, signTypedData will accept `uint` and `int`, but EIP 712 states that only integer types with their size are allowed.

Trying to use these should error, telling users that `uint256` and `int256` should be used instead when encountering these types.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the signTypedData entry point and trace validation of integer field types. Confirm that bare uint and int are rejected with guidance to use uint256 and int256, then verify the behavior with the relevant existing tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain, cryptography
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.