MetaMask / MetaMask/eth-sig-util

ABI encoding is out of date

Open
#134 1 comment 1 reaction 0 assignees View on GitHub
enhancement
Dominant language
TypeScript
Stars
583
Forks
228
Avg merge
11h 22m
Merged PRs (30d)
7

Description

This library is using `ethereumjs-abi`, which does not support the newer ABI_V2 spec and has been deprecated as a result: https://github.com/ethereumjs/ethereumjs-abi/issues/86

ABI_V2 changed the way `bytes` and `string` params are encoded and I know from personal experience that `ethereumjs-abi` does not decode newer messages properly. I don't know if the encoding side will work or not, but I would suggest considering a move to `ethers` if this repo is still in development.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the library's uses of ethereumjs-abi and its ABI encoding and decoding entry points. Check the ABI_V2 behavior for bytes and string parameters, then evaluate the suggested ethers migration. Done means newer ABI_V2 messages encode and decode correctly, with tests covering those parameter types.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.