MetaMask / MetaMask/eth-sig-util

signTypedData_v4 not according to specification

Open
#106 0 comments 8 reactions 1 assignee Claimed by @mcmire View on GitHub
bug team-wallet-framework
Dominant language
TypeScript
Stars
583
Forks
228
Avg merge
11h 22m
Merged PRs (30d)
7

Description

I was implementing `signTypedData_v4` for our project, and I have used the tests in this repo to make sure our implementation was sound.

I then noticed that `geth` provided their own https://github.com/ethereum/go-ethereum/blob/43c278cdf93d5469702fd1c2f570dbf3c1718ff0/signer/core/signed_data.go#L323 , so I plugged in the tests from this repo in `geth` and noticed that the behavior was not consistent.

Upon further investigation, I noticed that currently the behavior of signTypedData_v4 is not according to
https://eips.ethereum.org/EIPS/eip-712 when it comes to encoding arrays.

The eip states:
```
The array values are encoded as the keccak256 hash of the
concatenated encodeData of their contents
```

The behavior instead was to encode array values as the keccak256 of the
concatenated keccak256 of the values.

This worked well for primary types, but not for struct, as encodeData
per spec is:
```
The encoding of a struct instance is enc(value₁) ‖ enc(value₂) ‖ … ‖ enc(valueₙ) , i.e. the concatenation of the
encoded member values in the order that they appear in the type.
Each encoded member value is exactly 32-byte long.
```

Instead, we are using basically `hashStruct` instead of `encodeData`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.