MetaMask / MetaMask/eth-ledger-bridge-keyring
Please upgrade hw-app-eth to make it support EIP1559 and EIP2930
- Dominant language
- TypeScript
- Stars
- 84
- Forks
- 122
- PR merge metrics
- No merged PRs in 30d
Description
Hello,
We have recently merged https://github.com/LedgerHQ/ledgerjs/pull/637
which brings support for EIP1559 and EIP2930 in combination with Nano App v1.8.9 (currently available as a rc1 in Experimental Manager Provider 4 on Ledger Live)
I noticed that you will have to upgrade the library https://github.com/MetaMask/eth-ledger-bridge-keyring/blob/gh-pages/package.json#L23 to make it possible to do such transaction. This needs to be at least v6.3.0 of hw-app-eth (see https://github.com/LedgerHQ/ledgerjs/releases)
the v5 -> v6 shouldn't be breaking. It was made a major bump when we migrated from FlowType to TypeScript but we still target to JS bundle that should work without you to change anything beyond that.
It would be great if you have the ability to test this end to end, but if you can't, we would be happy to test on the matter (if you tell us the combination of what we need to do with MetaMask plugin for it to produce EIP1559 transactions)
Thanks and sorry for such short notice.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with package.json, where the hw-app-eth dependency is named, and review the requested upgrade to at least v6.3.0. Done means the dependency is upgraded and EIP1559 and EIP2930 transactions can be tested end to end with the relevant Ledger app and MetaMask plugin combination.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- blockchain
- Issue type
- Feature
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100