MetaMask / MetaMask/eth-ledger-bridge-keyring
Message replies are sometimes mixed up
- Dominant language
- TypeScript
- Stars
- 84
- Forks
- 122
- PR merge metrics
- No merged PRs in 30d
Description
When we send a message to the injected iframe, we assume the first reply we see is the response to that message. That might not be the case if we call the same method multiple times in quick succession.
To ensure we don't get our replies mixed up, we should attach a unique identifier to each message and look for it in the reply.
Contributor guide
No contributing guide indexed for this repository
Research direction
Inspect the code that sends messages to the injected iframe and receives replies. Trace how concurrent calls are currently matched, then add per-message identifiers and verify that each reply is associated with the request that created it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100