MetaMask / MetaMask/eth-ledger-bridge-keyring
`LedgerIframeBridge.destroy` does not remove the iframe from document
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 84
- Forks
- 122
- PR merge metrics
- No merged PRs in 30d
Description
The `LedgerIframeBridge.destroy` method does not destroy/remove the iframe from the document: when calling `destroy` and then `init` again, the document will have two Ledger iframes, which could lead to unexpected behavior. Because of this, the default behaviour of `setOptions` is duplicating the current iframe.
We should remove the current iframe from the document when `destroy` is called.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the LedgerIframeBridge.destroy method and trace how init and setOptions use the iframe lifecycle. Verify the current iframe is removed when destroy is called, and confirm that destroying then initializing again leaves only one Ledger iframe in the document.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100