MetaMask / MetaMask/eth-ledger-bridge-keyring

Ledger keyring should implement Keyring type

Open
#190 0 comments 0 reactions 0 assignees View on GitHub
team-wallet-framework wf-keyring
Dominant language
TypeScript
Stars
84
Forks
122
PR merge metrics
No merged PRs in 30d

Description

The Ledger keyring should extend the [Keyring type](https://github.com/MetaMask/utils/blob/main/src/keyring.ts#L47) as other keyrings.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the Keyring type at src/keyring.ts#L47, then locate the Ledger keyring implementation in this repository and compare it with the other keyrings. Update the type relationship so the Ledger keyring conforms to Keyring, and confirm the TypeScript checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
security
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.