MetaMask / MetaMask/eth-json-rpc-filters

Middleware should ideally have a `name` attribute

Open
#8 0 comments 0 reactions 0 assignees View on GitHub
team-wallet-framework wf-general-dx
Dominant language
JavaScript
Stars
29
Forks
39
PR merge metrics
No merged PRs in 30d

Description

This middleware does not result in a named object once assigned to the `engine`, making it harder to identify & cleanup listeners when a connection is closed, as I had to somewhat hack here:
https://github.com/MetaMask/metamask-extension/pull/6670/files

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing how middleware is assigned to the engine and how listeners are registered and cleaned up when a connection closes. Review the linked MetaMask pull request for the reported workaround and identify the middleware entry point involved. Done means the assigned middleware has an identifiable name that supports listener cleanup without that workaround.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api, backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.