MetaMask / MetaMask/eslint-config

Consider updating clients first before making changes to this repo

Open
#345 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
12
Forks
21
PR merge metrics
No merged PRs in 30d

Description

Extension, mobile, and core are behind the current version of our ESLint packages to varying degrees, and the chance that upgrading ESLint or enabling a previously disabled rule will cause numerous lint violations is fairly high. As raised by @legobeat, we shouldn't add any new rules or make any modifications to existing rules until we bring them up to date. If we want to introduce a new rule to a project, we should consider only enabling it there and not on an org level.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the ESLint package versions used by the extension, mobile, and core projects, then compare their configurations with this repository. Check which rules are disabled or shared at the organization level. Done means the client configurations are current and any new rule is enabled only where intended.

Written by the indexing model from the issue text.

Assessment

Tech stack
eslint, javascript
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.