MetaMask / MetaMask/create-release-branch

Don't create a branch if there are errors executing the release spec

Open
#136 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug team-core-platform
Dominant language
TypeScript
Stars
9
Forks
7
Avg merge
51m
Merged PRs (30d)
2

Description

If you run the tool and it executes the release spec, but there are errors — for instance, perhaps there are packages you ought to include that you haven't yet — the tool will abort, but it will still create the release branch and place you on it. If you decide to rename this branch or change the branch somehow, then you update the release spec and re-run the tool so that it re-reads the release spec, the tool won't know that changed the branch and will switch you back to the original branch (or recreate it if necessary).

To avoid that from happening, instead of creating the release branch in the first place, the tool should delete it if it detects an error.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named in the issue. Start by locating the release-spec execution and release-branch creation entry points, then reproduce an execution error; done means the command aborts without leaving the release branch created or checked out.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
cli, release
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.