Improve PhishingController error handling
- Dominant language
- TypeScript
- Stars
- 413
- Forks
- 308
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 253
Description
The PhishingController error handling for config updates has room for improvement. Currently config update failures are swallowed, so there is no opportunity for caller to discover this or retry. Some types of failure are not even logged.
We should ensure that config update failures are not suppressed with `updatePhishingLists` is called, so that the caller is aware when a failure has occurred. In any circumstance where it is necessary to suppress config update failures (e.g. in `test`), we should at least ensure the failure is logged, for debugging purposes.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start at the PhishingController entry point and trace where updatePhishingLists is called, including the test path mentioned in the issue. Determine which config-update failures are currently suppressed, then ensure callers can discover or retry failures and that any intentionally suppressed failures are logged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100