MetaMask / MetaMask/core

expose KeyringControler.verifyPassword

Open
#870 3 comments 0 reactions 0 assignees View on GitHub
team-wallet-framework wf-still-a-thing
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

Currently we are validating passwords by calling `await KeyringController.submitPassword(credentials.password)` which is a heavy operation and is dramatically slowing down the UI. I see that base KeyringController has a [verifyPassword method](https://github.com/MetaMask/KeyringController/blob/520dad38bad52429bf997373d98e90d138d8ba7f/index.js#L189) that is not exposed by this wrapper. We could expose this method so we can check passwords without running a full update.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the TypeScript wrapper around KeyringController, where password checks currently call submitPassword, and compare it with the linked base KeyringController.verifyPassword method. Expose the lighter verification entry point and confirm that callers can use it without triggering the full update operation.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authentication
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.