KeyringController:signTransaction does not cover all check for valid transaction
Open
team-wallet-framework
wf-bugs
- Dominant language
- TypeScript
- Stars
- 413
- Forks
- 308
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 253
Description
`KeyringController:signTransaction` fails in scenario like
```
const signedTx = await keyringController.signTransaction({}, account);
```
But not in scenario like:
```
const txParams = {
// no txParams passed
};
const unsignedEthTx = TransactionFactory.fromTxData(txParams, {
common: new Common(commonConfig),
freeze: false,
});
expect(unsignedEthTx.v).toBeUndefined();
const signedTx = await keyringController.signTransaction(
unsignedEthTx,
account,
);
```
Also the error message passed for wrong transaction is not very useful.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.