MetaMask / MetaMask/core

[base-controller] Make `name` a static property

Open
#7,632 0 comments 0 reactions 0 assignees View on GitHub
team-core-platform
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

The `BaseController` API has `name` as an instance property. This is always set statically, so we could make it a static property instead.

This would make it easier to generate a complete list of controller names in the client repositories. Currently we need to wait until after the controllers are constructed before getting a list of the `name` properties, which is an inconvenient restriction.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the BaseController implementation and references to its name property in the monorepo. Review how controllers are constructed and how client repositories obtain their names. Done means name is available statically before controller construction, with affected tests and usages passing.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.