MetaMask / MetaMask/core

Don't stub prototypes

Open
#750 0 comments 0 reactions 0 assignees View on GitHub
team-wallet-framework wf-test-quality-improvement
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

* Stubbing the prototype of the class under test is effectively the same as testing private functions, which is covered by #749.
* Stubbing the prototype of a library that isn't under test should be unnecessary. Anything we need to stub in a controller should be passed in as a parameter to the constructor.

Contributor guide

No contributing guide indexed for this repository

Research direction

No files or tests are identified. Search the repository's tests for prototype stubbing, then determine which stubs concern the class under test or libraries and replace the applicable setup with constructor-provided parameters; done means the targeted prototype stubs are removed without losing test coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.