Ensure all test assertions/matchers are executed during the test, before it ends
Open
Nobody has claimed this yet.
team-wallet-framework
wf-test-quality-improvement
- Dominant language
- TypeScript
- Stars
- 413
- Forks
- 308
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 253
Description
Somewhat related to #493. Some tests have expect calls in event handlers that aren't guaranteed to be executed during the test. If the code under test changes such that the event is never triggered, the test would pass without any indication that something was wrong.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the approach discussed in issue #493, then locate tests containing expect calls inside event handlers. Determine how those assertions can be verified before each test ends; done means a test fails when its expected event is never triggered, rather than passing silently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100