MetaMask / MetaMask/core

Minimize use of setup/teardown hooks (e.g. `before`, `beforeEach`, `after`, `afterEach`)

Open
#746 0 comments 0 reactions 0 assignees View on GitHub
team-wallet-framework wf-test-quality-improvement
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

* Keeping the setup for each unit test in the individual test makes it easier to understand what behaviour it is testing. A test should be readable in isolation, without cross-referencing elaborate setup steps.
* It should be easy for the reader to understand which setup steps the test relies upon.

Contributor guide

No contributing guide indexed for this repository

Research direction

No files, tests, or entry points are named. Start by surveying the TypeScript test suites for before, beforeEach, after, and afterEach hooks, then determine the intended scope and replacement pattern. Done would require a project-wide, agreed reduction in hook-based setup while keeping tests readable and passing.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
testing-qa
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.