MetaMask / MetaMask/core

Use Jest for stubbing modules rather than Sinon

Open
#744 0 comments 0 reactions 0 assignees View on GitHub
team-wallet-framework wf-test-quality-improvement
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

Jest provides a built-in means of stubbing modules, and it works just as well as Sinon. There really should be no reason to use Sinon (aside from perhaps stubbing timers).

Contributor guide

No contributing guide indexed for this repository

Research direction

No files, tests, or entry points are named. Review the TypeScript monorepo for Sinon module-stubbing usage and its Jest test setup; done means module stubbing uses Jest rather than Sinon, while any timer-stubbing exception is preserved.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.