MetaMask / MetaMask/core

Improve `PermissionSpecification` type safety

Open
#720 0 comments 0 reactions 0 assignees View on GitHub
team-wallet-framework wf-permission-controller-improvements
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

We should validate the `factory` and `validator` properties of permission specifications in `ValidPermissionSpecification`, just as we do with the restricted method.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating `ValidPermissionSpecification` and the existing validation for the restricted method. Trace how permission specifications are checked, then confirm that the `factory` and `validator` properties receive equivalent validation and that the relevant type-checking tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authorization
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.