MetaMask / MetaMask/core

eth-json-rpc-provider: Remove deprecated methods `send` and `sendAsync`

Open
#7,059 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

We should remove the deprecated `send` and `sendAsync` methods from the `InternalProvider`. The reason they're still around is to maintain compatibility between the `InternalProvider` and libraries like `eth-query` / `ethjs-query`. Consequently, we need to audit our dependencies that consume the `InternalProvider` for use of `send` and `sendAsync`, remove the usage from our forks of said dependencies, replace any third-party dependencies that can't be fixed, and then finally remove the methods, leaving only `InternalProvider.request()` (as is expected by e.g. `ethers`).

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by auditing dependencies that consume InternalProvider, especially eth-query and ethjs-query, for use of send and sendAsync. Review the project’s forks and any third-party dependencies that cannot be fixed. Done means those usages are removed or replaced and InternalProvider exposes only request().

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.