MetaMask / MetaMask/core

[eth-block-tracker] When destroying a PollingBlockTracker, unset the last timer created during the polling loop

Open
#6,869 0 comments 0 reactions 0 assignees View on GitHub
team-wallet-framework wf-test-quality-improvement
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

Failure to do so is causing "Jest did not exit one second after the test run has completed" in the tests for `eth-json-rpc-middleware`. See https://github.com/MetaMask/eth-json-rpc-middleware/pull/156.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the eth-block-tracker polling loop and its destroy path, then inspect the eth-json-rpc-middleware tests referenced in the issue and PR 156. Reproduce the Jest process-hanging behavior and verify that destroying the tracker clears the last timer created by the loop so the test run exits cleanly.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.