MetaMask / MetaMask/core

Limit significant digits in Token ContractExchangeRates values

Open
#639 0 comments 0 reactions 1 assignee View on GitHub

@adonesky1 is already working on this.

Since Nov 23, 2021.

team-assets
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

Daniel Suchy discovered an error in Swaps where contract exchange rates with more than 15 significant digits was causing this error:
![image](https://user-images.githubusercontent.com/34557516/143066850-ec417e3b-d28f-4b6d-b069-a905bf708777.png)

- We should make the TokenRatesController ContractExchangeRates robust against this issue and investigate/address downstream implications.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.