MetaMask / MetaMask/core

@metamask/foundryup "Invalid version" should not check version starts with 'v'

Open Beginner friendly
#6,245 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

E.g. when running `yarn mm-foundryup install --version=stable`

It checks if it is a valid version string starting with 'v'.
However, options description of the `--version`: Specify the version (see: https://github.com/foundry-rs/foundry/tags) [default: "nightly"]

Both nightly and stable are valid tags. This logic should be removed or changed to allow `stable` or `nightly` tag/version.

https://github.com/MetaMask/core/blob/afd5e91404cf6da2a28ed87e7ec3652f4b7aa08b/packages/foundryup/src/options.ts#L17-L25

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with packages/foundryup/src/options.ts, especially the validation around the --version option, and reproduce the issue with yarn mm-foundryup install --version=stable. Check the existing version rules against the option description and Foundry tags; done means stable and nightly are accepted without breaking valid version handling.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
cli, tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.