MetaMask / MetaMask/core

[`polling-controller`] `network-controller` should be a direct dependency, not a peer dependency

Open
#6,002 0 comments 0 reactions 0 assignees View on GitHub
team-wallet-framework wf-developer-velocity
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

`polling-controller` seems to only use types from `network-controller` and does not talk to this controller. Therefore, its dependency on `network-controller` should be defined under `dependencies`, not `devDependencies` + `peerDependencies`.

Fixing this would reduce the number of packages that need to be released if a major version of `network-controller` is released.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in the polling-controller package configuration and inspect how network-controller is currently declared under devDependencies and peerDependencies. Confirm the package only uses its types, then update the dependency declarations so network-controller is a direct dependency and verify the package metadata and release relationship are correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.