MetaMask / MetaMask/core

[controller-utils] Improve service policy circuit breaker error

Open
#5,857 0 comments 0 reactions 0 assignees View on GitHub
enhancement team-wallet-framework wf-general-dx
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

The error thrown when the service policy circuit breaks is not expressive enough. The error does not indicate which service failed.

We should augment the error (e.g. catch and re-throw) to include some identifying information about the service. For example, in the case of the RPC service we should include the RPC hostname or network config ID.

Contributor guide

No contributing guide indexed for this repository

Research direction

The issue points to the controller-utils service-policy circuit-breaker error path; start there and trace the RPC service context available when it fails. Check how the RPC hostname or network config ID can identify the service, then verify that the resulting error distinguishes the failed service and that coverage exists for the changed behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.