MetaMask / MetaMask/core

Remove current chain from addTokens function

Open
#5,559 0 comments 0 reactions 0 assignees View on GitHub
team-assets
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

tokenController:
The `addToken` method currently relies on a fallback to a default `chainId` and includes a TODO note to remove this behavior once the method is fully parameterized by `chainId` (via `networkClientId`). Additionally, the token metadata fetch is not yet parameterized by `networkClientId`.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating tokenController and reading the addToken method, especially its chainId fallback and TODO. Trace how networkClientId is passed into the method and how token metadata is fetched. Done means removing the current-chain fallback and parameterizing both token handling and metadata fetching by networkClientId.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.