MetaMask / MetaMask/core

Fix: Metamask relies on incorrect eth_ RPC endpoint for gas estimation

Open
#5,417 1 comment 0 reactions 0 assignees View on GitHub
Gas team-confirmations
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

https://github.com/MetaMask/core/blob/f3636adffef458ed51eea454c6c4e006e1ef33b3/packages/gas-fee-controller/src/gas-util.ts#L123

eth_estimateGas RPC should not be used for 1559 estimations, instead eth_feeHistory should be used: https://github.com/ethereum/execution-apis/blob/main/src/eth/fee_market.yaml

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in packages/gas-fee-controller/src/gas-util.ts around line 123 and inspect how the 1559 estimation path selects its RPC method. Compare the expected fee data with the execution-apis eth_feeHistory definition. Done means 1559 estimations no longer use eth_estimateGas and instead use the appropriate fee-history endpoint.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, blockchain
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.