Audit the controllers to ensure our controller guidelines/templates provide good advice
- Dominant language
- TypeScript
- Stars
- 413
- Forks
- 308
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 253
Description
This ticket was brought up from an incident that occurred not he mobile client where a controller don't have initial state passed in the Engine which resulted in the contact list being flushed on app restart.
The outcome for this ticket will be to audit the controllers to ensure our controller guidelines/templates provide good advice on initial state.
Related issue: https://github.com/MetaMask/metamask-mobile/issues/12044
Fix: https://github.com/MetaMask/metamask-mobile/pull/12089
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by reading the incident described in related issue #12044 and the fix in pull request #12089, then review the controllers and their guidelines/templates for advice about initial state. Done means the controller guidance and templates clearly address initial state and avoid the reported data-loss scenario.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100