MetaMask / MetaMask/core

[Assets Controllers] Remove old polling APIs

Open
#5,165 0 comments 0 reactions 0 assignees View on GitHub
team-assets
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

- TokenDetectionController
- TokenListController
- TokenRatesController

Still have the old polling API with `start()` and `stop()` functions. These should no longer be used, and safe to remove. The `startPolling(input)` and `stopPollingByPollingToken(pollingToken)` functions from the base class `StaticIntervalPollingController` should be used instead.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with TokenDetectionController, TokenListController, and TokenRatesController, then inspect their inherited StaticIntervalPollingController APIs. Find the old start() and stop() methods and their references, and confirm that polling uses startPolling(input) and stopPollingByPollingToken(pollingToken) instead. Done means the old polling APIs are removed from all three controllers without remaining references.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend-api-design
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.