MetaMask / MetaMask/core

[selected-network-controller] Track `metamask` selected domain

Open
#5,107 3 comments 0 reactions 3 assignees Claimed by @jiexi View on GitHub
enhancement team-wallet-api-platform
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

The `SelectedNetworkController` doesn't track the selected chain for the `metamask` domain, instead it relies on the NetworkController for this. As we make progress with eliminating reliance upon the "globally selected network", we want to move the `metamask` domain "current chain" tracking to the `SelectedNetworkController` so that all "selected chains" are tracked in the same place.

Additional details from @adonesky1 :

Migrate the (global) `selectedNetworkClientid` from the `NetworkController` to state in the domains object in the `SelectedNetworkController`.
- This will require updating selectors to point to this new location for this state.
- This will also require updating listeners.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.