MetaMask / MetaMask/core

Create more informative error logs

Open
#5,068 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

team-identity team-notifications
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

Notification/Identity team related.

I'm looking through sentry at some of our error logs we emit, I think we can do a better job at adding some metadata to these logs.

Fetch requests:
- add status code (this will help us differentiate 400, 500, 431, 413, ..., errors)
- maybe add the endpoint that we were trying to hit
- profileId can also be handy if we need to perform additional back-end investigations.

Impossible states
- for sections of our typescript code that we deemed impossible to reach, lets add the variable/s that could have caused it to reach those areas.

Failure states
- for sections we've marked as failure states, lets try to add additional metadata to inform us on why these failed

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the TypeScript fetch-request, impossible-state, and failure-state error logs that are sent to Sentry. Review which metadata is available at each site, including status code, endpoint, profileId, and relevant variables. Done means the requested diagnostic context is included consistently and the affected error logs remain valid.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
observability
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.