[Performance] - Phishing list not performant on mobile devices
- Dominant language
- TypeScript
- Stars
- 413
- Forks
- 308
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 253
Description
Problem:
- Currently the Phishing List provide a large set of data (>3MB) to clients via the Phishing Controller. This controller then performs a large set of filtering [computations on the lists](https://github.com/MetaMask/core/blob/8fb04fc2134bd69b47c5420cab640738c07122f3/packages/phishing-controller/src/utils.ts#L56).
- The large data set and client side filtering impact the 2 primary constraints that mobile devices have: network bandwidth and memory constraints
Example of API Data from a mobile client:
- https://phishing-detection.metafi.codefi.network/v1/diffsSince/1712766668?_=1725983486634
Preferred API requirements for the Phishing List
- [Mobile API Best Practice Table](https://docs.google.com/document/d/1BHihktA41CyQX-fH3qXmSmic9ylvPMCHHGv2YbgjA0M/edit?usp=sharing)
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with packages/phishing-controller/src/utils.ts, especially the linked filtering code, and review the example diffsSince API response and the Mobile API Best Practice Table. Define the API and client-side changes needed to reduce mobile bandwidth, memory use, and filtering work; done means the phishing list meets the documented API requirements.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api, performance
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100